#13891: Default parameters for Graph.plot() and Graph.show()
---------------------------------+------------------------------------------
Reporter: ncohen | Owner: jason, ncohen, rlm
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.7
Component: graph theory | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers: Punarbasu Purkayastha,
Sébastien Labbé
Authors: Nathann Cohen | Merged in:
Dependencies: #13862 | Stopgaps:
---------------------------------+------------------------------------------
Comment (by ncohen):
Hellooooooooo Sebastien !
I can now answer your many comments, and write down what we said orally
across the table `:-)`
1/2) I fixed this doc, but only where it is related to what this ticket
implements, and not related to the `"@options"` decorator. This has to be
documented where the decorator is defined, not in these files.
3) There is a link from the documentation of show toward graph_plot
4) Fixed
D) Because I want those two methods to appear in the doc, even if they
begin with a `_`
What this new patch does :
1) It changes the documentation of GraphPlot so that the list of
admissible keywords appear only once, and in the documentation.
2) The GraphPlot.plot() method accepts any options, and ignores them. I
remove the `**kwds` in its definition, and remove the long description of
its possible parameters
3) I remove two default arguments of Poset.plot() which were ignored
4) There's a dprecation warning when a wrong keyword is used
Tell me what you think of it !
Nathann
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13891#comment:24>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
