#5658: [with patch, needs review] Efficiency improvement in generic
order_from_multiple()
-------------------------+--------------------------------------------------
Reporter: cremona | Owner: tbd
Type: enhancement | Status: new
Priority: minor | Milestone: sage-3.4.1
Component: algebra | Keywords: generic group order
-------------------------+--------------------------------------------------
Comment(by cremona):
Thanks for the fast review.
Here is what val_unit does. Given a nonzero integer or rational n and a
prime p, you can write n uniquely as {{{n = m*p^e}}} where m is not
divisible by p (if rational, neither the numerator nor the denominator of
m is divisible by p). We call e the valuation of m at p (which can be
obtained on its own by n.valuation(p)) and m the "unit" part of n at p
(which can be obtained on its own by n.prime_to_m_part(p)). Using
val_unit() gives these together which is more efficient as they are
computed together.
It's an operation frequently needed in number theory!
I added "needs review" which I forgot to do earlier. If you are happy
with val_unit() you can change that, or I can hit someone else to take a
look.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5658#comment:2>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---