#793: wrapper for hyperelliptic curve zeta functions
---------------------------+------------------------------------------------
Reporter: dmharvey | Owner: was
Type: enhancement | Status: new
Priority: major | Milestone: sage-3.4.1
Component: number theory | Keywords:
---------------------------+------------------------------------------------
Comment(by GeorgSWeber):
Unfortunate.
The code was excellently commented, in fact the comments of the internal
functions were so good, it just slipped by me that the mandatory
doctesting lines were missing. (Which IMHO are trivial to add in this
patch.)
And if it is difficult to find "special" doctests for internal functions,
one always has the possibility to do (another slightly modified instance
of) the "outer" computation as a test and write "#implicit doctest" as
comment. This serves the intended purpose (and I strongly guess neither
Michael, nor William, would object). All in all, another to-be-better-
documented issue.
With regard to the p-adic precision, I'd say "functionality first and
optimizations later" (the patch as-is is mathematically correct :-) ), but
that's my own personal opinion.
Cheers,
gsw
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/793#comment:14>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
