#14059: Fix refcount/deallocation of integers
------------------------------+---------------------------------------------
Reporter: SimonKing | Owner: rlm
Type: defect | Status: needs_review
Priority: blocker | Milestone: sage-5.7
Component: memleak | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers:
Authors: Simon King | Merged in:
Dependencies: | Stopgaps:
------------------------------+---------------------------------------------
Comment (by jpflori):
Replying to [comment:43 SimonKing]:
> Concerning removal of the INCREF: I could imagine removing it is a bad
idea. After all, the allocator appears to be of general use. Hence, we
have no guarantee that in other (potential) uses of sage.misc.allocator we
could guarantee ''externally'' that the dummy will live forever.
I meant the other INCREF mentioned here
http://trac.sagemath.org/sage_trac/ticket/2435#comment:6 and with no info
on why it would be needed.
About the INCREF on dummy, my point is that it is useless as dummy is
cdefed and won't be automatically collected.
But indeedit could be called on something not cdefed so let's keep it.
>
> Plus: hook_tp_functions (and thus Py_INCREF) is called exactly once. I
don't think that the slowdown caused by it really matters...
Yeah, even the other which gets called every time the method is called
won't be that terrible, I was kidding.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14059#comment:44>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
