#13732: Fix output of real data in matplotlib PDF backend
------------------------------------------------+---------------------------
Reporter: john_perry | Owner: jason, was
Type: defect | Status: needs_review
Priority: trivial | Milestone: sage-5.7
Component: graphics | Resolution:
Keywords: PDF, matplotlib, save, alpha | Work issues:
Report Upstream: N/A | Reviewers: Karl-Dieter
Crisman
Authors: John Perry | Merged in:
Dependencies: | Stopgaps:
------------------------------------------------+---------------------------
Changes (by {'newvalue': u'John Perry', 'oldvalue': ''}):
* reviewer: => Karl-Dieter Crisman
* author: => John Perry
Comment:
> It turns out that '''all''' the other files I had worked on were okay.
That gave me the idea to look at how `arc()` handles the same problems,
since it also accepts the `alpha` keyword. By mimicking that solution
(which also showed me why the coordinates don't raise the same error), I
avoided the whole `!= None` problem.
Excellent. I'm sure that I've seen all this before, too, and didn't
recognize it. That's the problem with viewing patches and not the whole
code.
I suppose one could run into trouble anyway, if one used the `Disk`
primitive and called this method, but that's not intended use and it's
pervasive in the code, so it would be another ticket, if even worth
opening.
You may want to fix the commit line.
{{{
Track 13732: fix output of real data in matplotlib PDF backend
}}}
but otherwise positive review.
----
> To be honest, it looks as if someone either noticed this problem before
& tried to fix it, remembering everything except `disk()`. Here I was
thinking I was making a great contribution, when in fact I was just
cleaning up behind someone else. I'll go weep into some hot tea. ;-)
Hey, it got fixed, right? :-)
> By the way, I hope you're not too snowed in, way up there in New
England.
Oh yes. Took over two hours to shovel all the way out to where the plows
"created" the street so the car is ready to get out - though now church is
cancelled due to lack of parking, so I guess tomorrow is another day at
home.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13732#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
