#14038: Let libgap build a shared library on Cygwin
---------------------------------------------------+------------------------
       Reporter:  jpflori                          |         Owner:  tbd        
               
           Type:  defect                           |        Status:  
needs_review              
       Priority:  major                            |     Milestone:  sage-5.7   
               
      Component:  packages                         |    Resolution:             
               
       Keywords:  cygwin spkg libgap               |   Work issues:  integrate 
changes upstream
Report Upstream:  N/A                              |     Reviewers:  
Jean-Pierre Flori         
        Authors:  Volker Braun, Jean-Pierre Flori  |     Merged in:             
               
   Dependencies:                                   |      Stopgaps:             
               
---------------------------------------------------+------------------------
Changes (by vbraun):

  * status:  needs_work => needs_review


Old description:

> We need to pass -no-undefined to libtool, the proper place is in
> libgap_la_LDFLAGS, potentially  only on Cygwin and other Windows systems
> (have a look in GMP/MPIR/MPFR for examples), but should not hurt anyway
> elsewhere if added unconditionally.
>
> (By the way the spkg-install script is terrible, does not use $MAKE, use
> [ ] and [[ ]], sets CXXFLAGS but does not export it...)
>

> http://boxen.math.washington.edu/home/jpflori/libgap-4.5.7.p1.spkg

New description:

 We need to pass -no-undefined to libtool, the proper place is in
 libgap_la_LDFLAGS, potentially  only on Cygwin and other Windows systems
 (have a look in GMP/MPIR/MPFR for examples), but should not hurt anyway
 elsewhere if added unconditionally.

 (By the way the spkg-install script is terrible, does not use $MAKE, use [
 ] and [[ ]], sets CXXFLAGS but does not export it...)


 http://www.stp.dias.ie/~vbraun/Sage/spkg/libgap-4.5.7.p1.spkg

--

Comment:

 Done.

 
https://bitbucket.org/vbraun/libgap/commits/4ff0ca203c552df03a621eecaf64f1b1f2c5d691

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14038#comment:32>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to