#13440: Adding reverse_edge() function to DiGraph
---------------------------------+------------------------------------------
Reporter: egunawan | Owner: jason, ncohen, rlm
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.7
Component: graph theory | Resolution:
Keywords: digraph | Work issues:
Report Upstream: N/A | Reviewers: Gregg Musiker, Nathann Cohen
Authors: Emily Gunawan | Merged in:
Dependencies: | Stopgaps:
---------------------------------+------------------------------------------
Comment (by gmoose05):
Dear Nathann, Emily, and David,
Greetings from Sage Days 45. Thank you again Nathann for the review
patch, these modifications looked great to me! Looking over it this
evening, I found a few small issues, but I fixed them and uploaded them as
a second review patch. I'll wait for you to get a chance to take a look
but barring any further issues, I am also ready for a positive review.
Just to summarize my changes:
i) inplace=True is the default so Fixed this typo in the Examples,
ii) In the example
{{{
Note that in the following graph, specifying ``multiedges = False`` will
result in overwriting the label of `(1,2)` with the label of `(2,1)`::
sage: D = DiGraph( [(1, 2, 'B'), (2, 1,'A'), (2, 3, None)] )
sage: D.edges()
[(1, 2, 'B'), (2, 1, 'A'), (2, 3, None)]
sage: D.reverse_edge(2,1, multiedges=False)
sage: D.edges()
[(1, 2, 'B'), (2, 3, None)]
}}}
the computational behavior differed from the description. (By the way, I
also like the choice to overwrite the label.) This alerted me to small
typo in the code (in the multiedges=False) case. This code and the
example are now fixed.
Gregg
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13440#comment:36>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
