#13424: Compute Mutation Class for Cluster Algebra Seed or Cluster Quiver
-------------------------------------------+--------------------------------
Reporter: gmoose05 | Owner: sage-combinat
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.7
Component: combinatorics | Resolution:
Keywords: cluster algebra, quiver | Work issues:
Report Upstream: N/A | Reviewers: Gregg Musiker
Authors: Christian Stump | Merged in:
Dependencies: #13369 | Stopgaps:
-------------------------------------------+--------------------------------
Comment (by stumpc5):
Here is a first review:
- we should add some tests that the computed class sizes coincide with the
expected class sizes in QuiverMutationType
- the non-iter methods (mutation_class <-> mutation_class_iter) should
also contain examples since these are the typical used methods
- l1318: "# runs forever without the mutation type recognition patch
applied" we should make clear what this means (I don't even know
currently).
- recheck that the file mutation_class.py is organized well.
- building the doctest and going through the docs.
Beside these, the patch looks good to me: the code is a little complicated
but the methods are well-documented.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13424#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
