#6495: Build the reference manual incrementally
---------------------------------------------------------------+------------
       Reporter:  mpatel                                       |         Owner: 
 jdemeyer                    
           Type:  enhancement                                  |        Status: 
 needs_work                  
       Priority:  major                                        |     Milestone: 
 sage-5.8                    
      Component:  documentation                                |    Resolution: 
                             
       Keywords:  days38                                       |   Work issues: 
                             
Report Upstream:  N/A                                          |     Reviewers: 
 Volker Braun, Florent Hivert
        Authors:  Mitesh Patel, John Palmieri, Florent Hivert  |     Merged in: 
                             
   Dependencies:  5.7.beta2 + #13064, #8327, #13891            |      Stopgaps: 
                             
---------------------------------------------------------------+------------
Changes (by jdemeyer):

  * status:  positive_review => needs_work


Comment:

 In `devel/sage/doc/common/custom-sphinx-build.py`, you write
 {{{
     def write(self, str):
         try:
             self._write(str)
         except:
             import traceback
             traceback.print_exc(file=self._stream)
 }}}
 One should never use bare `except:` statements, because these usually
 catch too much, for example `KeyboardInterrupt`s. Use `except
 StandardError` if you want to catch all errors, or catch a specific
 exception instead.

 And in {{{devel/sage/doc/common/themes/sageref/layout.html}}}, indentation
 is done mostly with spaces but there are a few TABs. You should use spaces
 consistently.

 But most importantly: the code actually seems to work now! It still needs
 buildbot testing though.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/6495#comment:256>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to