#7886: Implement conjugacy classes
-------------------------------------+--------------------------------------
Reporter: jlopez | Owner: joyner
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-5.8
Component: group theory | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers: David Joyner, Travis
Scrimshaw
Authors: Javier López Peña | Merged in:
Dependencies: | Stopgaps:
-------------------------------------+--------------------------------------
Changes (by tscrim):
* reviewer: David Joyner => David Joyner, Travis Scrimshaw
Comment:
Hey Javier,
Replying to [comment:20 jlopez]:
> Thanks for looking at my patch! I have a complicated work situation
during the week, but will fix the docstring style and rebase again over
sage 5.7 on Friday or Saturday.
Thank you! There's not a huge rush, just ping back when it's done and I'll
give it a look-over.
> Not sure what you mean about the patch header message. Do you mean the
Spanish characters in my name? That is automatically added by my hg
configuration, but it seems that trac does not support UTF-8; I added the
appropriate encoding to the python files, but don't know how to do it for
the patch (and don't feel inclined to change my name either). If it is
about the cruft that came from patch folding, I will take care of that as
well.
If you look at the beginning of the patch, you have the following:
{{{
# HG changeset patch
# User Javier López Peña <[email protected]>
# Date 1360004753 0
# Node ID 2782ba59f14a8dafdb44e05a67972e5a9d4db0cf
# Parent fa8decac55338225dc33568ad600c261fc777b4c
* * *
Trac 7886: Conjugacy classes
* * *
Trac 7886: Created module for conjugacy classes of finite groups.
Added wrappers for GAP functions and naive fallback method.
* * *
Trac 7886: Conjugacy classes
}}}
In particular, the line right after the {{{# Parent ...}}} should be a one
line summary of the patch with the ticket number (such as {{{Trac 7886:
Conjugacy classes}}} which is probably what you originally had). This can
get mangled when folding patches. You can change this by doing a `qrefresh
-e`. I don't think the encoding for your name in the header is important.
Gracias por tu trabajo,[[BR]]
Travis
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7886#comment:21>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
