#14120: Add constant_coefficient method for Laurent polynomials
------------------------------------+---------------------------------------
Reporter: tscrim | Owner: tscrim
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.8
Component: algebra | Resolution:
Keywords: days45 | Work issues:
Report Upstream: N/A | Reviewers: Kannappan Sampath
Authors: Travis Scrimshaw | Merged in:
Dependencies: | Stopgaps:
------------------------------------+---------------------------------------
Changes (by tscrim):
* status: needs_work => needs_review
Comment:
First off, thank you for doing the review.
Replying to [comment:3 knsam]:
> The docstring claims that, if the number of inputs is less than the
number of variables, all the remaining[trailing] variables would have
their exponent set to zero. But, for some reason, the implementation (and
hence the examples) raises a `TypeError`.
>
> IMHO, it would be nice to implement the behaviour suggested by the
docstring. (of course, the other case, where no. of variables <= no. of
inputs is being handled correctly.)
I made it consistent with other multivariate polynomial rings, however I
forgot to correct the doc. This is done. I've also added in two more
methods for consistancy and changed the output of the iterator.
> And, could we also please document that multivariate laurent polynomials
are not iterable, as implemented, by adding an example, before we get
complaints "like" [http://trac.sagemath.org/sage_trac/ticket/14124 this].
This does not make sense to me. They are iterable with this patch.
> Building documentation, there is a warning, which is fairly easy to fix:
I think the complaint is about the method `__call__`
>
> {{{
> <autodoc>:0: WARNING: Block quote ends without a blank line; unexpected
unindent.
> }}}
I do not get this with the revised patch.
> Finally, that we are changing this file, one might as well go ahead and
clean up all the codifications: self is almost never codified, for
instance and such documentation stuff...
You are welcome to do so on another ticket. That is outside of the purview
of this one. I did it in the methods this patch touches.
> The already extant method `cofficient()` would benefit from adding r:
`r"""` just so that the `\frac` with backslash is picked up properly by
Sphinx. There is a misspelt word in the Note that is already there too.
(constnat...)
Fixed.
Best,
Travis
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14120#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
