#14054: Cythoned UniqueRepresentation
-----------------------------------------------+----------------------------
Reporter: SimonKing | Owner: tbd
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.8
Component: performance | Resolution:
Keywords: cython UniqueRepresentation | Work issues:
Report Upstream: N/A | Reviewers: Travis
Scrimshaw
Authors: Simon King | Merged in:
Dependencies: #14017, #6495, #14159 | Stopgaps:
-----------------------------------------------+----------------------------
Comment (by SimonKing):
Replying to [comment:43 tscrim]:
> Replying to [comment:42 SimonKing]:
> > Well, that would still mean that we need to actually import it.
>
> I thought if we turn it into a python class, we wouldn't need to cimport
it
Its original use ''requires'' cimport. Namely, it had no `__init__`, and
setting the hash value requires writing into the cdef attribute `_hash`,
thus we need cimport. Now, I added an init method---hence, ''now'' an
import is enough.
> (To me honest, part of me is still wondering if we even really need a
deprecation warning since it is
> such a low-level base class.)
Same here...
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14054#comment:44>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
