#14166: Use "cp -pR", not "cp -pr" in spkg-install
------------------------------------------+---------------------------------
Reporter: jhpalmieri | Owner: jdemeyer
Type: defect | Status: needs_review
Priority: blocker | Milestone: sage-5.8
Component: scripts | Resolution:
Keywords: cp symlink OSX Solaris | Work issues:
Report Upstream: N/A | Reviewers:
Authors: John Palmieri | Merged in:
Dependencies: | Stopgaps:
------------------------------------------+---------------------------------
Old description:
> According to [http://www.gnu.org/savannah-
> checkouts/gnu/autoconf/manual/autoconf-2.68/html_node/Limitations-of-
> Usual-Tools.html#Limitations-of-Usual-Tools], we should avoid the "-r"
> flag for `cp`. On linux, using "-r" or "-R" doesn't make a difference,
> but on OS X, the man page for cp says that with the -r flag, "it does not
> correctly copy special files, symbolic links, or fifo's."
>
> As a result, after building from scratch using #6495 on OS X or
> !OpenSolaris, the various files `doc/en/reference/MODULE/conf.py`, which
> are all supposed to by symlinks to `doc/en/reference/conf_sub.py`, are
> copies of that file instead, and the hg repo is not clean. So I'm marking
> this as a blocker. The only other instances of "cp -pr" in any spkg are
> in R spkg and in sage-make_devel_packages, neither of which causes
> problems, so we shouldn't worry about them.
>
> -----
>
> Apply [attachment:trac_14166-sage.patch].
New description:
According to [http://www.gnu.org/savannah-
checkouts/gnu/autoconf/manual/autoconf-2.68/html_node/Limitations-of-
Usual-Tools.html#Limitations-of-Usual-Tools], we should avoid the "-r"
flag for `cp`. On linux, using "-r" or "-R" doesn't make a difference, but
on OS X, the man page for cp says that with the -r flag, "it does not
correctly copy special files, symbolic links, or fifo's."
As a result, after building from scratch using #6495 on OS X or
!OpenSolaris, the various files `doc/en/reference/MODULE/conf.py`, which
are all supposed to by symlinks to `doc/en/reference/conf_sub.py`, are
copies of that file instead, and the hg repo is not clean. So I'm marking
this as a blocker. The only other instances of "cp -pr" in any spkg are in
R spkg and in sage-make_devel_packages, neither of which causes problems,
so we shouldn't worry about them.
-----
Apply [attachment:trac_14166-sage-tar.patch].
--
Comment (by jhpalmieri):
I like the tar approach. Here's a patch.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14166#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
