#13102: PermutationGroup.all_blocks from GAP
---------------------------------+------------------------------------------
Reporter: ncohen | Owner: joyner
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.8
Component: group theory | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers:
Authors: Nathann Cohen | Merged in:
Dependencies: | Stopgaps:
---------------------------------+------------------------------------------
Comment (by benjaminfjones):
Hi Nathann,
Looks good, I'm happy to see more of GAP wrapped. A couple of suggestions,
1. Strictly speaking, the function doesn't return a list of blocks, but
as the GAP manual puts it: "a list of representatives of all block systems
for a permutation group G acting transitively on the points moved by the
group." I think it's clear from the output that what a user is getting is
not a partition of the set, but a list of reps for an invariant partition,
but it would be nice if the documentation mentions this.
2. In the `INPUT` description, I would change representants -->
representatives.
3. Add a description of `OUTPUT`. In particular, I would have expected
the function to return a list of lists of ints in all cases (each inner
list representing a partition of the set). Instead, it returns either a
list of lists, or a list of lists of lists depending on the input.
Otherwise, looks great to me! I think the enhancements @jasonbhill has
brought up should be made a new ticket (which he can create if he's still
interested).
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13102#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
