#12561: Factoring padic polynomials
---------------------------------------------------+------------------------
Reporter: bsinclai | Owner: roed
Type: enhancement | Status: new
Priority: major | Milestone: sage-5.8
Component: padics | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers:
Authors: Brian Sinclair, Sebastian Pauli | Merged in:
Dependencies: | Stopgaps:
---------------------------------------------------+------------------------
Comment (by spice):
Patch applies correctly on 7.5 and all doctests written so far pass.
However:
In the doctest from `pfactortree()`:
{{{
sage: from sage.rings.polynomial.padics.factor.factoring import
jorder4,pfactortree
sage: f = ZpFM(2,24,'terse')['x']( (x^32+16)*(x^32+16+2^16*x^2)+2^34 )
sage: pfactortree(f) # long (3.8s)
[(1 + O(2^24))*x^64 + (65536 + O(2^24))*x^34 + (32 + O(2^24))*x^32 +
(1048576 + O(2^24))*x^2 + (256 + O(2^24))]
}}}
This is just returning the polynomial unfactored, so demonstrably the
factoring isn't working here. We should get:
{{{
sage: f = ZpFM(2,24,'terse')['x']( (x^32+16)*(x^32+16+2^16*x^2)+2^34 )
sage: f.factor()
((1 + O(2^24))*x^32 + (65536 + O(2^24))*x^2 + (16 + O(2^24))) * ((1 +
O(2^24))*x^32 + (16 + O(2^24)))
}}}
Also, we should rework this code so that a sage Factorization object is
returned, and that pfactortree is called by the `.factor()` method
attached to p-adic polynomials.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12561#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
