#6567: function to test whether or not some integer is a primitive root modulo n
-----------------------------------+----------------------------------------
       Reporter:  mvngu            |         Owner:  was                       
           Type:  enhancement      |        Status:  needs_review              
       Priority:  major            |     Milestone:  sage-5.8                  
      Component:  number theory    |    Resolution:                            
       Keywords:  primitive roots  |   Work issues:                            
Report Upstream:  N/A              |     Reviewers:  Julian Rueth, Simon Spicer
        Authors:  David Roe        |     Merged in:                            
   Dependencies:  #12116           |      Stopgaps:                            
-----------------------------------+----------------------------------------
Changes (by spice):

  * reviewer:  Julian Rueth => Julian Rueth, Simon Spicer


Comment:

 Patch applies, but with the (proposed) change to #12116 - swapping the
 order integers returned by `perfect_power()` so that
 `(a^b).perfect_power()` returns `(a,b)` and not `(b,a)` - the code breaks
 on perfect powers or twice perfect powers. A simple single line change
 fixes this; I've uploaded a new patch with this fix. Line 1485 goes from
 {{{
 k, p = odd.perfect_power()
 }}}
 to
 {{{
 p, k = odd.perfect_power()
 }}}
 Everything else is good.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/6567#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to