#12116: perfect_power for integers
----------------------------------------------------------------+-----------
       Reporter:  roed                                          |         
Owner:  AlexGhitza                              
           Type:  enhancement                                   |        
Status:  needs_review                            
       Priority:  major                                         |     
Milestone:  sage-5.8                                
      Component:  basic arithmetic                              |    
Resolution:                                          
       Keywords:                                                |   Work 
issues:                                          
Report Upstream:  Fixed upstream, but not in a stable release.  |     
Reviewers:  David Loeffler, Aly Deines, Simon Spicer
        Authors:  David Roe                                     |     Merged 
in:                                          
   Dependencies:  #10596, #12363, #12638                        |      
Stopgaps:                                          
----------------------------------------------------------------+-----------

Comment (by spice):

 We missed another line. In `self.factor_aurifeuillian()` in factorint.pyx,
 we have
 {{{
 ...
 b = n + x
 exp, b = b.perfect_power()
 if exp > 1:
 ...
 }}}
 This must now become
 {{{
 ...
 b = n + x
 b, exp = b.perfect_power()
 if exp > 1:
 ...
 }}}
 otherwise this method breaks with the new ordering of values returned by
 `perfect_power()`. I've uploaded a new patch that fixes this.

 Hopefully that should be it.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12116#comment:30>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to