#13991: Mitigate speed regressions in symmetric function related code due to 
#12313
------------------------------------------+---------------------------------
       Reporter:  nbruin                  |         Owner:  sage-combinat
           Type:  task                    |        Status:  needs_review 
       Priority:  major                   |     Milestone:  sage-5.8     
      Component:  combinatorics           |    Resolution:               
       Keywords:                          |   Work issues:               
Report Upstream:  N/A                     |     Reviewers:  Simon King   
        Authors:                          |     Merged in:               
   Dependencies:  #13605, #14225, #14228  |      Stopgaps:               
------------------------------------------+---------------------------------
Changes (by SimonKing):

  * status:  new => needs_review
  * reviewer:  => Simon King


Comment:

 With sage-5.8.beta0 plus
 {{{
 trac11490-coercion_tutorial.patch
 14182_whitespace.patch
 trac_13618-rings_doc_real-ts.patch
 trac_13618-rings_doc_complex-ts.patch
 trac_13618-rings_doc_others-ts.patch
 trac_14040_housekeeping.patch
 trac_14040_repr_option.patch
 trac_14040_doctest.patch
 trac_14040_review.patch
 trac14054_fast_methods-5.8.patch
 }}}
 I obtain
 {{{
 sage: from sage.combinat.sf.k_dual import AffineSchurFunctions
 sage: F =
 
AffineSchurFunctions(SymmetricFunctions(QQ['t']).kBoundedQuotient(Integer(4),t=Integer(1)))
 sage: %time TestSuite(F).run()
 CPU times: user 5.90 s, sys: 0.12 s, total: 6.02 s
 Wall time: 7.39 s
 sage: %time TestSuite(F).run()
 CPU times: user 3.49 s, sys: 0.03 s, total: 3.53 s
 Wall time: 3.53 s
 }}}
 and
 {{{
 sage -t sage/combinat/sf
 ...
 All tests passed!
 Total time for all tests: 100.5 seconds
 }}}
 and second time
 {{{
 All tests passed!
 Total time for all tests: 101.8 seconds
 }}}

 Adding
 {{{
 trac_12313-mono_dict-combined-random-sk.patch
 trac_13387-combined.patch
 trac_13387-guard_gc.patch
 trac_14159_weak_value_triple_dict.patch
 trac_14159_use_cdef_get.patch
 trac12951_cached_extension.patch
 trac_14214-cython_homset.patch
 trac_14214-backup_cache.patch
 trac_14063-remove_cc_compositions-ts.patch
 trac_13688-finite_sets_cardinality_override-ts.patch
 trac_14138.patch
 trac_14138-doctests.patch
 trac_13605-partition_options-ts.patch
 trac_14011-Sphinx_roles-fh.patch
 trac_14054-fix-rigged-list.2.patch
 trac_11410-zero_one_sequence_partitions-pod.v2.patch
 trac_11410-zero_one_sequence_partitions-review-ts.patch
 trac_14225-partition_classcall_private.patch
 }}}
 I obtain
 {{{
 sage: from sage.combinat.sf.k_dual import AffineSchurFunctions
 sage: F =
 
AffineSchurFunctions(SymmetricFunctions(QQ['t']).kBoundedQuotient(Integer(4),t=Integer(1)))
 sage: %time TestSuite(F).run()
 CPU times: user 10.30 s, sys: 0.26 s, total: 10.56 s
 Wall time: 10.72 s
 sage: %time TestSuite(F).run()
 CPU times: user 9.58 s, sys: 0.09 s, total: 9.68 s
 Wall time: 9.69 s
 }}}
 and
 {{{
 sage -t sage/combinat/sf
 ...
 All tests passed!
 Total time for all tests: 107.6 seconds
 }}}
 and second time
 {{{
 All tests passed!
 Total time for all tests: 107.5 seconds
 }}}

 Adding
 {{{
 trac_14228-sym_speedup-ts.patch
 trac_14228-reviewer.patch
 }}}
 I obtain
 {{{
 sage: from sage.combinat.sf.k_dual import AffineSchurFunctions
 sage: F =
 
AffineSchurFunctions(SymmetricFunctions(QQ['t']).kBoundedQuotient(Integer(4),t=Integer(1)))
 sage: %time TestSuite(F).run()
 CPU times: user 5.50 s, sys: 0.09 s, total: 5.59 s
 Wall time: 5.60 s
 sage: %time TestSuite(F).run()
 CPU times: user 3.13 s, sys: 0.00 s, total: 3.13 s
 Wall time: 3.13 s
 }}}
 and
 {{{
 sage -t sage/combinat/sf
 ...
 All tests passed!
 Total time for all tests: 102.2 seconds
 }}}
 and second time
 {{{
 All tests passed!
 Total time for all tests: 102.2 seconds
 }}}

 Hence, it seems to me that #14228 did indeed fix the problem.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13991#comment:58>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to