#14254: OverflowErrors in TripleDictEraser
----------------------------------+-----------------------------------------
       Reporter:  jdemeyer        |         Owner:  robertwb       
           Type:  defect          |        Status:  positive_review
       Priority:  blocker         |     Milestone:  sage-5.8       
      Component:  coercion        |    Resolution:                 
       Keywords:                  |   Work issues:                 
Report Upstream:  N/A             |     Reviewers:  SimonKing      
        Authors:  Jeroen Demeyer  |     Merged in:                 
   Dependencies:  #13387          |      Stopgaps:                 
----------------------------------+-----------------------------------------
Changes (by SimonKing):

  * status:  needs_review => positive_review
  * reviewer:  => SimonKing


Comment:

 OK, I believe Jeroen when he says that building the documentation on his
 32-bit systems works with the patch, while it reproducibly failed without
 the patch.

 I think the solution makes sense: id(X) returns a positive number, and
 this may very well be beyond what a signed number type of the same size
 (such as Py_ssize_t) can take.

 The patchbot gives a green blob, too. Hence, I hope it is safe to give
 this a positive review (but I think #14159 will be better, on the long
 run).

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14254#comment:39>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to