#5727: [with patch, positive review] Improve doctest coverage for sage/modular
---------------------------+------------------------------------------------
Reporter: davidloeffler | Owner: craigcitro
Type: defect | Status: new
Priority: major | Milestone: sage-3.4.2
Component: modular forms | Keywords: doctests
---------------------------+------------------------------------------------
Comment(by was):
REVIEW:
* Put backquotes aroudn start_weight in the modform_generators
docstring:
{{{ - start_weight -- an integer (default: 2) }}}
* A doctest fails on 32-bit OS X:
{{{
sage -t --long devel/sage/sage/modular/arithgroup/arithgroup_perm.py
**********************************************************************
File "/Users/wstein/build/sage-3.4.1.rc1/devel/sage-
main/sage/modular/arithgroup/arithgroup_perm.py", line 202:
sage: cmp(G, 1)
Expected:
-1
Got:
1
**********************************************************************
1 items had failures:
1 of 6 in __main__.example_9
***Test Failed*** 1 failures.
}}}
I recommend changing the doctest to:
{{{
sage: cmp(G,1) in [-1,1]
}}}
since it depends on the OS.
These are trivial changes, so I've posted a tiny patch that adds them and
given this a positive review.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5727#comment:2>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
