#5478: [with patch, needs review] RestrictedPartitions is very slow and a huge
memory hog
---------------------------+------------------------------------------------
Reporter: ddrake | Owner: ddrake
Type: defect | Status: new
Priority: major | Milestone: sage-combinat
Component: combinatorics | Keywords: combinat, partitions, gap
---------------------------+------------------------------------------------
Comment(by ddrake):
Replying to [comment:10 hivert]:
> Some comment on the first patch:
>
> I'm not a native English speaker but it seems to me that
> If ``starting=p`` is passed, then the combinatorial class of
partitions greater than or equal to `p` in lexicographic order is
returned.
> is clearer if phrased
> If ``starting=p`` is passed, then the combinatorial class of
partitions with part greater than or equal to `p` in lexicographic order
is returned.
"p" refers to a partition, not to a part, so the text is okay. Perhaps we
should make that more clear, though. I plan on opening a ticket to improve
the documentation in partition.py, so we can do that then.
Replying to [comment:9 hivert]:
> > Anyone reviewing this might want to look at my test script:
restricted_partitions_test_suite.sage. I've run over 10,000 successful
tests with it.
>
> This script is great. I should be put in sage in one place or one other.
If someone tries to
> optimize your code (eg: Cythonize), he surely will be happy to have your
test code. Why not
> shipping it into the patch with a more explicit name and a one-line
example on how to use it
> with the comment " #longtest " ?
Well, right now, the script only halts if it finds an error, so it would
be a really, really long test. :)
The tests also can use lots of memory, since it puts a list of the
partitions into memory. But if anyone thinks (a mildly modified version
of) the script should get run on a "long" test, I'm happy to have it
included.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5478#comment:11>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
