#5724: [with patch; needs review] get coverage of quotient_ring_element.py to
100%
---------------------------------+------------------------------------------
Reporter: was | Owner: malb
Type: defect | Status: new
Priority: major | Milestone: sage-3.4.1
Component: commutative algebra | Keywords:
---------------------------------+------------------------------------------
Comment(by malb):
'''Review'''
* I don't think {{{sage: a._QuotientRingElement__rep}}} belongs as an
example since it encourages to use hidden attributes directly
* Why don't you replace the doctest in {{{_add_}}} and friends with
example which involve {{{+}}} and friends? This way it is clear when this
function is called.
If this is addressed, I'd give it a positive review.
A side question: It seems {{{QuotientRingElement}}} is exclusively used
for quotient rings over (multivariate) polynomials ideals. Shouldn't it be
moved & renamed to {{{polynomial.QuotientRingPolynomial}}}? Also, I guess
the API of QRE should be adapted to have all the methods of multivariate
polynomials (except those which don't make sense). That'd be another
ticket though.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5724#comment:4>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
