#14310: CBC compilation problem -- optional arguments in a .pxd file
--------------------------------------+-------------------------------------
       Reporter:  ncohen              |         Owner:  ncohen    
           Type:  defect              |        Status:  needs_work
       Priority:  major               |     Milestone:  sage-5.9  
      Component:  linear programming  |    Resolution:            
       Keywords:                      |   Work issues:            
Report Upstream:  N/A                 |     Reviewers:            
        Authors:  Nathann Cohen       |     Merged in:            
   Dependencies:                      |      Stopgaps:            
--------------------------------------+-------------------------------------
Changes (by pmueller):

  * status:  needs_review => needs_work


Comment:

 The patch installed fine, and some simple tests which work with different
 solvers work with the coin-cbc solver too.

 However, as suggested in the section `Reviewing a patch', I did run
 {{{./sage --testall --long}}}, and got two failures:

 {{{
 **********************************************************************
 File
 "/home/mueller/local/sage-5.8/devel/sage/doc/en/thematic_tutorials/linear_p
 rogramming.rst", line 281:
     sage: p.solve()
 Expected:
     3.1502766806530307
 Got:
     3.15027668065
 **********************************************************************
 File
 "/home/mueller/local/sage-5.8/devel/sage/doc/en/thematic_tutorials/linear_p
 rogramming.rst", line 291:
     sage: sum(weight[o] * taken[o] for o in L)
 Expected:
     0.6964959796619171
 Got:
     0.696495979661917
 **********************************************************************
 1 items had failures:
    2 of  18 in __main__.example_1
 ***Test Failed*** 2 failures.
 For whitespace errors, see the file
 /home/mueller/.sage//tmp/linear_programming_6443.py
 }}}
 and another one
 {{{
 **********************************************************************
 File "/home/mueller/local/sage-5.8/devel/sage/sage/numerical/mip.pyx",
 line 1853
 :
     sage: b.solver_parameter("simplex_or_intopt", "simplex_only")
 Exception raised:
     Traceback (most recent call last):
       File "/home/mueller/local/sage-5.8/local/bin/ncadoctest.py", line
 1231, in
  run_one_test
         self.run_one_example(test, example, filename, compileflags)
       File "/home/mueller/local/sage-5.8/local/bin/sagedoctest.py", line
 38, in
 run_one_example
         OrigDocTestRunner.run_one_example(self, test, example, filename,
 compile
 flags)
       File "/home/mueller/local/sage-5.8/local/bin/ncadoctest.py", line
 1172, in
  run_one_example
         compileflags, 1) in test.globs
       File "<doctest __main__.example_36[8]>", line 1, in <module>
         b.solver_parameter("simplex_or_intopt", "simplex_only")###line
 1853:
     sage: b.solver_parameter("simplex_or_intopt", "simplex_only")
       File "generic_backend.pyx", line 837, in
 sage.numerical.backends.generic_b
 ackend.GenericBackend.solver_parameter
 (sage/numerical/backends/generic_backend.
 c:6199)
       File "generic_backend.pyx", line 861, in
 sage.numerical.backends.generic_b
 ackend.GenericBackend.solver_parameter
 (sage/numerical/backends/generic_backend.
 c:6103)
     NotImplementedError
 **********************************************************************
 File "/home/mueller/local/sage-5.8/devel/sage/sage/numerical/mip.pyx",
 line 1854
 :
     sage: b.solver_parameter("verbosity_simplex", "GLP_MSG_ALL")
 Exception raised:
     Traceback (most recent call last):
       File "/home/mueller/local/sage-5.8/local/bin/ncadoctest.py", line
 1231, in
  run_one_test
         self.run_one_example(test, example, filename, compileflags)
       File "/home/mueller/local/sage-5.8/local/bin/sagedoctest.py", line
 38, in
 run_one_example
         OrigDocTestRunner.run_one_example(self, test, example, filename,
 compile
 flags)
       File "/home/mueller/local/sage-5.8/local/bin/ncadoctest.py", line
 1172, in
  run_one_example
         compileflags, 1) in test.globs
       File "<doctest __main__.example_36[9]>", line 1, in <module>
         b.solver_parameter("verbosity_simplex", "GLP_MSG_ALL")###line
 1854:
     sage: b.solver_parameter("verbosity_simplex", "GLP_MSG_ALL")
       File "generic_backend.pyx", line 837, in
 sage.numerical.backends.generic_b
 ackend.GenericBackend.solver_parameter
 (sage/numerical/backends/generic_backend.
 c:6199)
       File "generic_backend.pyx", line 861, in
 sage.numerical.backends.generic_b
 ackend.GenericBackend.solver_parameter
 (sage/numerical/backends/generic_backend.
 c:6103)
     NotImplementedError
 **********************************************************************
 1 items had failures:
    2 of  14 in __main__.example_36
 ***Test Failed*** 2 failures.
 For whitespace errors, see the file /home/mueller/.sage//tmp/mip_20568.py
 }}}
 Not sure if that matters, but my understanding (as a beginner) is that
 this test is expected to produce not even one error, no matter how
 harmless it is.

 -- Peter Müller

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14310#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to