#5606: [with patch, needs work?] color complex plotting
----------------------+-----------------------------------------------------
Reporter: robertwb | Owner: was
Type: defect | Status: new
Priority: major | Milestone: sage-3.4.1
Component: graphics | Keywords:
----------------------+-----------------------------------------------------
Comment(by was):
> I've updated the patch, should pass doctests now.
As a reviewer I am finding this very annoying. It means I have to somehow
revert the patch in my own tree before I can safely apply yours *and* it
makes it very very hard for me to see what you actually changed. I would
*much* rather have a part 2 patch that applies on top of the first one.
On a clean 3.4.1.rc1 build (which I think never had #5606 applied, so far
as I can tell) I get:
{{{
sage:
hg_sage.apply('http://trac.sagemath.org/sage_trac/attachment/ticket/5606/5606
-complex-plot.patch'
)
Attempting to load remote file: http://trac.sagemath.org/sage_trac/raw-
attachment/ticket/5606/5606-complex-plot.patch
Loading: [..]
cd "/scratch/wstein/build/sage-3.4.1.rc1/devel/sage" && hg status
cd "/scratch/wstein/build/sage-3.4.1.rc1/devel/sage" && hg status
cd "/scratch/wstein/build/sage-3.4.1.rc1/devel/sage" && hg import
"/scratch/wstein/sage/temp/sage.math.washington.edu/1031/tmp_2.patch"
applying
/scratch/wstein/sage/temp/sage.math.washington.edu/1031/tmp_2.patch
patching file sage/misc/log.py
Hunk #1 FAILED at 64
1 out of 1 hunks FAILED -- saving rejects to file sage/misc/log.py.rej
patching file sage/misc/mathml.py
Hunk #1 FAILED at 26
1 out of 1 hunks FAILED -- saving rejects to file sage/misc/mathml.py.rej
file sage/plot/complex_plot.pyx already exists
1 out of 1 hunks FAILED -- saving rejects to file
sage/plot/complex_plot.pyx.rej
abort: patch failed to apply
sage: hg_sage.log()
changeset: 11933:470a0a0e9a2c
tag: tip
user: [email protected]
date: Sun Apr 05 23:49:53 2009 -0700
summary: 3.4.1.rc1
...
}}}
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5606#comment:10>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
