#14055: Fix sage-cleaner
----------------------------------+-----------------------------------------
Reporter: jdemeyer | Owner: leif
Type: defect | Status: needs_review
Priority: critical | Milestone: sage-5.9
Component: scripts | Resolution:
Keywords: orphans | Work issues:
Report Upstream: N/A | Reviewers: Punarbasu Purkayastha, Leif
Leonhardy
Authors: Jeroen Demeyer | Merged in:
Dependencies: | Stopgaps:
----------------------------------+-----------------------------------------
Changes (by leif):
* keywords: => orphans
* reviewer: => Punarbasu Purkayastha, Leif Leonhardy
Comment:
THERE ARE STILL SOME INSTANCES OF UPPERCASE SAGE.
I don't like the mixture of tmp, temp, TMP and TEMP or whatever.
[[BR]]
`temp` and `tmp` shouldn't be hardcoded.
"Deleting `.../spawned_processes`" gets printed even if
`.../spawned_processes` is not a directory (`not e`), and also `rmtree()`
is attempted, ignoring any `OSError`.
[[BR]]
I don't like `"%s" % i` where `i` is (or should be) an `int`.
[[BR]]
Command line option handling is certainly suboptimal. (`argv[1]` could be
a `float` as well, there's no usage, and additional parameters simply get
ignored.)
Likewise, if `DOT_SAGE` isn't set, an ugly `KeyError` is raised, instead
of printing a meaningful message.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14055#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
