#13425: Compute mutation type of a ClusterSeed or ClusterQuiver
---------------------------------------------------+------------------------
Reporter: gmoose05 | Owner:
sage-combinat
Type: enhancement | Status:
positive_review
Priority: major | Milestone: sage-5.9
Component: combinatorics | Resolution:
Keywords: cluster algebra, quiver, days45 | Work issues:
Report Upstream: N/A | Reviewers: Christian
Stump, Gregg Musikier
Authors: Gregg Musiker, Christian Stump | Merged in:
Dependencies: #13424 | Stopgaps:
---------------------------------------------------+------------------------
Comment (by jdemeyer):
There are various problem with the documentation:
{{{
dochtml.log:[combinat ]
/padic/release/merger/sage-5.9.beta1/local/lib/python2.7/site-
packages/sage/combinat/cluster_algebra_quiver/quiver.py:docstring of
sage.combinat.cluster_algebra_quiver.quiver.ClusterQuiver.is_finite:5:
WARNING: Literal block expected; none found.
dochtml.log:[combinat ]
/padic/release/merger/sage-5.9.beta1/local/lib/python2.7/site-
packages/sage/combinat/cluster_algebra_quiver/quiver.py:docstring of
sage.combinat.cluster_algebra_quiver.quiver.ClusterQuiver:41: WARNING:
Bullet list ends without a blank line; unexpected unindent.
dochtml.log:[combinat ]
/padic/release/merger/sage-5.9.beta1/local/lib/python2.7/site-
packages/sage/combinat/cluster_algebra_quiver/quiver_mutation_type.py:docstring
of
sage.combinat.cluster_algebra_quiver.quiver_mutation_type.save_quiver_data:1:
WARNING: Inline literal start-string without end-string.
}}}
Also, I wondering whether you are using `assert` correctly. `assert`
should only be used to check for bugs, not for bad user input. In other
words, if there is any way to produce an `AssertionError` by supplying bad
input to a public function, that is by definition a bug. Use `ValueError`
or `TypeError` (or other exceptions) for bad user input.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13425#comment:17>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
