#5039: Create a class for SetPartition (with no s)
------------------------------------+---------------------------------------
Reporter: slabbe | Owner: slabbe
Type: enhancement | Status: needs_info
Priority: major | Milestone: sage-5.9
Component: combinatorics | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers:
Authors: Travis Scrimshaw | Merged in:
Dependencies: | Stopgaps:
------------------------------------+---------------------------------------
Changes (by ncohen):
* status: needs_review => needs_info
Comment:
Helloooooooooo !!
Several remarks :
* Could you update the ticket's title and description ?
* Why did you move the description of the data structure from the module
to the function ? `:-/` I prefer when it is at the top of the html
documentation, and here you have no idea of what is happening in that
module... Plus there is a function and three classes in that module, so
something should be said at the module level `:-/`
* I know it's not the point of this ticket but what would you think of
changing `cardinality()` so that it actually returns the cardinality of
the partition, and not the cardinality of its union ? And have another
method named "`number_of_elements`" which would return what `cardinality`
currently returns ? Would make more sense, wouldn't it ? It does not have
to be in this ticket, though.
Nice patch though ! Always good to improve the doc `:-)`
Nathann
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5039#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
