#14268: Remove #define ulong
----------------------------------+-----------------------------------------
       Reporter:  jdemeyer        |         Owner:  GeorgSWeber
           Type:  defect          |        Status:  needs_work 
       Priority:  major           |     Milestone:  sage-5.9   
      Component:  build           |    Resolution:             
       Keywords:                  |   Work issues:             
Report Upstream:  N/A             |     Reviewers:             
        Authors:  Jeroen Demeyer  |     Merged in:             
   Dependencies:  #14265          |      Stopgaps:             
----------------------------------+-----------------------------------------
Description changed by jdemeyer:

Old description:

> The {{{#define ulong unsigned long}}} can cause conflicts with glibc's
> `<sys/types.h>` in `-std=gnu99` mode and with zn_poly (which has been
> patched to work around this, but it shouldn't be).
>
> In FLINT, we should replace
> {{{
> #define ulong unsigned long
> }}}
> by
> {{{
> typedef unsigned long ulong
> }}}
>
> '''Apply''':
>  1. spkg
> [http://sage.math.washington.edu/home/jdemeyer/spkg/flint-1.5.2.p4.spkg]
> ([attachment:flint-1.5.2.p4.diff diff])
>  1. spkg
> [http://sage.math.washington.edu/home/jdemeyer/spkg/zn_poly-0.9.p11.spkg]
> ([attachment:zn_poly-0.9.p11.diff diff])
>  1. to the Sage library: [attachment:14268_remove_c99.patch]

New description:

 The {{{#define ulong unsigned long}}} in FLINT can cause conflicts with
 glibc's `<sys/types.h>` in `-std=gnu99` mode and with zn_poly (which has
 been patched to work around this, but it shouldn't be).

 In FLINT, we should replace
 {{{
 #define ulong unsigned long
 }}}
 by
 {{{
 typedef unsigned long ulong
 }}}

 '''Apply''':
  1. spkg
 [http://sage.math.washington.edu/home/jdemeyer/spkg/flint-1.5.2.p4.spkg]
 ([attachment:flint-1.5.2.p4.diff diff])
  1. spkg
 [http://sage.math.washington.edu/home/jdemeyer/spkg/zn_poly-0.9.p11.spkg]
 ([attachment:zn_poly-0.9.p11.diff diff])

--

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14268#comment:15>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to