#10058: Segfault in backward and inverse FFT for 2**n elements
----------------------------------------------------------+-----------------
Reporter: mpatel | Owner:
jason, jkantor
Type: defect | Status:
needs_review
Priority: major | Milestone:
sage-5.9
Component: numerical | Resolution:
Keywords: gsl, fft, segfault | Work issues:
Report Upstream: N/A | Reviewers:
Luis Felipe Tabera Alonso
Authors: Mike Hansen, Luis Felipe Tabera Alonso | Merged in:
Dependencies: | Stopgaps:
----------------------------------------------------------+-----------------
Comment (by ppurka):
Hello! The patches look good. I have the following comments about the doc
patch.
1. Can you fix the documentation of the functions? It should be like this
{{{
def function(n, p=1):
"""
Determine the ``n``-th number. Note that I didn't use `n`
since single backticks will format it in latex.
INPUT:
- ``n`` -- Integer. Description of this parameter
- ``p`` -- Integer (default: 1). Description of this parameter.
}}}
2. The following line {{{180 See `self.plot` for details. }}}
should use `:meth:` to refer to plot. Also, `self.plot` is used in some
other functions.
{{{
See :meth:`plot` for details.
}}}
3. `pi` should also be changed to float in this line
{{{
191 pi = sage.symbolic.constants.pi # should append .n()
at the end.
}}}
4. In the function `plot`, the INPUT needs a fix. It should be like this.
Also, see 1. for the comment about default values and formatting.
{{{
- ``style`` -- Style of the plot, options are ``"rect"`` or ``"polar"``
}}}
You can refer to the
[http://www.sagemath.org/doc/developer/conventions.html#documentation-
strings developer guide] for more information about the formatting of
docstrings.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10058#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
