#13624: KeyError raised by GraphLatex.dot2tex_picture when edge_labels=True
------------------------------------------+---------------------------------
       Reporter:  slabbe                  |         Owner:  tbd         
           Type:  defect                  |        Status:  needs_review
       Priority:  major                   |     Milestone:  sage-5.9    
      Component:  packages: optional      |    Resolution:              
       Keywords:  dot2tex, graph drawing  |   Work issues:              
Report Upstream:  N/A                     |     Reviewers:              
        Authors:  Nicolas M. Thiéry       |     Merged in:              
   Dependencies:                          |      Stopgaps:              
------------------------------------------+---------------------------------
Changes (by nthiery):

  * status:  needs_work => needs_review


Comment:

 Replying to [comment:43 slabbe]:
 > I just added a patch which fixes the broken doctests seen by the
 patchbot. I also added a doctest that make sure the issue of this ticket
 is solved. I also fixed an # optional - dot2tex, graphviz which was not up
 to date.

 Thanks Sébastien! I looked at your reviewer patch, and it looks good to
 me. Let's see what the patchbot says. Back to needs review for the first
 patch.

 > Finally I realize that some optional test are broken. Like this one that
 we can see in the doc of `layout_graphviz`. This may be considered in
 another ticket.
 >
 > {{{
 > sage: g = digraphs.ButterflyGraph(2)
 > sage: g.plot(layout = "graphviz", prog = "neato") # optional - dot2tex,
 graphviz
 > Traceback (most recent call last):
 > ...
 > ValueError: invalid literal for int() with base 10: '67.297'
 > }}}

 +1 since the tests were already failing before this ticket. This is
 now #14408 which is about updating the dot2tex spkg.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13624#comment:44>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to