#5756: [with patch; needs review] improve coverage of rings/morphism.pyx (and 
fix
5 bugs in morphism.pyx)
-------------------------+--------------------------------------------------
 Reporter:  was          |       Owner:  mabshoff  
     Type:  enhancement  |      Status:  new       
 Priority:  major        |   Milestone:  sage-3.4.1
Component:  doctest      |    Keywords:            
-------------------------+--------------------------------------------------

Comment(by cremona):

 Starting to review this, which is in itself non-trivial!

 There is some strange terminology here.  I'm not sure what a "Set-
 theoretic ring endomorphism of Integer Ring" is meant to be, let alone a
 "set-theoretic ring".  I think that what is meant is (in the first case) a
 map between rings which is not a ring homomorphism, such as a section of a
 surjective map.

 Also the term "lift" is used for such a section, i.e. if f:R-->S is the
 surjective ring hom and h:S-->R is a section (so f(h(s))==s for all s in
 S) then the map h is being called a lift, where I would say that the
 element h(s) is a lift of s.  And "cover"?   Here R is being called a
 cover of S?

 I think it would be helpful if somewhere in this file this terminology is
 defined since not all of it is so standard...

 A more proper review will follow.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5756#comment:4>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of 
Reinventing the Wheel

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to 
[email protected]
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to