#14287: Split _test_elements_eq
--------------------------------+-------------------------------------------
Reporter: saraedum | Owner: nthiery
Type: enhancement | Status: needs_review
Priority: trivial | Milestone: sage-5.9
Component: categories | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers: David Roe
Authors: Julian Rueth | Merged in:
Dependencies: #14284 | Stopgaps:
--------------------------------+-------------------------------------------
Changes (by tscrim):
* status: needs_work => needs_review
Old description:
> Currently ``_test_elements_eq`` tests for reflexivity, symmetry, and
> transitivity. However, transitivity does not hold in padic rings. This
> tickets splits ``_test_elements_eq`` into these three subtests, so they
> that we can override the transitivity test for padic implementations.
>
> -----
>
> Apply
> 1. [attachment:trac_14287.patch]
> 1. [attachment:14287_review_58rc0.patch]
New description:
Currently ``_test_elements_eq`` tests for reflexivity, symmetry, and
transitivity. However, transitivity does not hold in padic rings. This
tickets splits ``_test_elements_eq`` into these three subtests, so they
that we can override the transitivity test for padic implementations.
-----
Apply:
- [attachment:trac_14287-rebased.patch]
--
Comment:
I've uploaded a rebased patch to at least `5.9.beta1` and has the review
patch folded in. Since this touches a lot of files, I'd like someone with
a more recent beta version to make sure it applies before setting this
back to positive review.
For patchbot:
Apply: trac_14287-rebased.patch
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14287#comment:16>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
