#14411: Disjoint Sets --> iter
---------------------------------------+------------------------------------
Reporter: elixyre | Owner: jason, ncohen, rlm
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.9
Component: misc | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers: Travis Scrimshaw
Authors: Jean-Baptiste Priez | Merged in:
Dependencies: | Stopgaps:
---------------------------------------+------------------------------------
Changes (by tscrim):
* status: new => needs_review
* reviewer: => Travis Scrimshaw
* component: graph theory => misc
* type: PLEASE CHANGE => enhancement
Comment:
A few things I would like to see:
- Reference the ticket number in the commit message
- Use double quotes instead of single quotes for consistency
- Since dictionaries are non-deterministic in their ordering, could you
change the last test to something like
{{{
sage: L = [s for s in d]
sage: len(L)
3
}}}
Also you probably could just return
`self.root_to_elements_dict().itervalues()` since it is an iterator object
(it avoids a level of indirection).
Thanks,[[BR]]
Travis
PS - I'm assuming this was suppose to be set to needs_review. Sorry if it
wasn't.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14411#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
