#13766: No conversion from unit group to number field.
---------------------------------+------------------------------------------
       Reporter:  mderickx       |         Owner:  davidloeffler
           Type:  defect         |        Status:  needs_review 
       Priority:  major          |     Milestone:  sage-5.9     
      Component:  number fields  |    Resolution:               
       Keywords:                 |   Work issues:               
Report Upstream:  N/A            |     Reviewers:               
        Authors:                 |     Merged in:               
   Dependencies:                 |      Stopgaps:               
---------------------------------+------------------------------------------

Comment (by mstreng):

 Replying to [comment:7 mderickx]:
 > Well, I have no idea wich ticket fixed this.

 #13687

 > And I couldn't find a doctest which tests this somewhere.

 Coercion from the abstract unit group to the number field is tested by
 #13687.
 {{{
 sage: UK.gen(0) + K.one()   # coerce abstract generator into number field
 }}}
 Conversion the other way around already had a test.
 {{{
 sage: [UK(u) for u in (x^4-1).roots(K,multiplicities=False)]
 }}}
 The coercion framework will then make sure that "in" also works correctly.
 I don't think another test is necessary.

 Enhancing the documentation by explaining that "in" works in this case is
 nice, but then make sure the English grammar is correct in the patch as
 well. And there are issues like the fact that {{{u0^6}}} may depend on the
 pari version, since any even exponent is correct, so this test will break
 later.

 I propose to just close this ticket as duplicate instead :)

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13766#comment:8>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to