#14346: The pari spkg is patching upstream too heavily
--------------------------------------+-------------------------------------
Reporter: Snark | Owner: tbd
Type: enhancement | Status: new
Priority: major | Milestone: sage-wishlist
Component: packages: standard | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers:
Authors: | Merged in:
Dependencies: | Stopgaps:
--------------------------------------+-------------------------------------
Description changed by jdemeyer:
Old description:
> This spkg has 15 patches, with the following :
> 1. get_ld.patch: author known, pure packaging - GOOD
> 2. get_tests.patch: author known, pure packaging - GOOD
> 3. get_config_options.patch: author known, upstream-worthy, no comment
> says it was forwarded, which probably means it wasn't - BAD
> 4. get_fltk.patch: author known, upstream-worthy, no comment says it was
> forwarded, which probably means it wasn't - BAD
> 5. get_X11.patch: author known, upstream-worthy, no comment says it was
> forwarded, which probably means it wasn't - BAD
> 6. get_dlcflags.patch: author known, upstream-worthy, a comment says
> upstream has a partial fix but doesn't say that better patch has been
> forwarded, which probably means it wasn't - BAD
> 7. install_doc_no_make.patch: author known, pure packaging - GOOD
> 8. perl_path.patch: author known, pure packaging - GOOD
> 9. cygwin_dll_a.patch: author known, pure packaging - GOOD
> 10. KERNELCFLAGS.patch: author unknown, you have to look at a bug report
> to see who the author is and that it was forwarded upstream - HALF-GOOD
> 11. src/kernel/gmp/mp.c: author unknown, upstream-worthy, no comment
> says it was forwarded, which probably means it wasn't - BAD
> 12. GCC_PR49330.patch: author unknown, upstream-worthy, no comment says
> it was forwarded, which probably means it wasn't - BAD
> 13. trac_13902_determinant.patch: author unknown, upstream backport,
> hopefully not too modified - GOOD?
> 14. galoisanalysis_p4.patch: author unknown, upstream-worthy, no comment
> says it was forwarded, which probably means it wasn't - BAD
> 15. polred.patch: author unknown, upstream backport + added function --
> the upstream backport is ok, adding a new function isn't [that should be
> done in the sage library] - BAD
New description:
This spkg has 15 patches, with the following:
Good:
* get_ld.patch: author known, pure packaging
* get_tests.patch: author known, pure packaging
* install_doc_no_make.patch: author known, pure packaging
* perl_path.patch: author known, pure packaging
* cygwin_dll_a.patch: author known, pure packaging
* trac_13902_determinant.patch: author unknown, upstream backport,
hopefully not too modified
Half-good:
* KERNELCFLAGS.patch: author unknown, you have to look at a bug report to
see who the author is and that it was forwarded upstream
Bad:
* get_config_options.patch: author known, upstream-worthy, no comment
says it was forwarded, which probably means it wasn't
* get_fltk.patch: author known, upstream-worthy, no comment says it was
forwarded, which probably means it wasn't
* get_X11.patch: author known, upstream-worthy, no comment says it was
forwarded, which probably means it wasn't
* get_dlcflags.patch: author known, upstream-worthy, a comment says
upstream has a partial fix but doesn't say that better patch has been
forwarded, which probably means it wasn't
* src/kernel/gmp/mp.c: author unknown, upstream-worthy, no comment says
it was forwarded, which probably means it wasn't
* GCC_PR49330.patch: author unknown, upstream-worthy, no comment says it
was forwarded, which probably means it wasn't
* galoisanalysis_p4.patch: author unknown, upstream-worthy, no comment
says it was forwarded, which probably means it wasn't
* polred.patch: author unknown, upstream backport + added function -- the
upstream backport is ok, adding a new function isn't [that should be done
in the sage library]
--
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14346#comment:21>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
