#14151: Update GMP-ECM to 6.4.4
--------------------------------------+-------------------------------------
Reporter: zimmerma | Owner: tbd
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-5.9
Component: packages: standard | Resolution:
Keywords: spkg | Work issues: SPKG,txt clean up
Report Upstream: N/A | Reviewers: François Bissey
Authors: Jeroen Demeyer | Merged in:
Dependencies: | Stopgaps:
--------------------------------------+-------------------------------------
Changes (by fbissey):
* status: positive_review => needs_work
* work_issues: => SPKG,txt clean up
Comment:
Replying to [comment:35 zimmerma]:
> sorry Francois was quicker than myself. Here are my 2 cents.
>
> In SPKG.txt:
> {{{
> * We currently work around a linker bug on MacOS X 10.5 PPC (with
> GCC 4.2.1) which breaks 'configure' if debug symbols are enabled.
> This *might* get fixed in later upstream releases.
> }}}
> Is that still true, since there is no patch any more?
>
I believe it is fixed as from the description of the patch:
{{{
* configure.patch:
- Disable "asm-redc" on 32-bit Darwin PPCs (upstream revision
1516 / bug
#10646).
(Note that this upstream patch is likely to slow down GMP-ECM
on 64-bit
PPC CPUs running (32-bit) MacOS X, since the extended
instruction set of
the CPU is no longer exploitet. A proper fix would just pass
an option
to Apple's assembler to allow the use of the extended
instruction set.)
- Fix compilation error on x86 CPUs supporting SSE2.
(Sage trac #10252,
upstream revision 1546).
}}}
So there is mention of two revisions in gmp-ecm taking care of the problem
from that patch. But good spotting, SPKG.txt needs cleaning to remove that
statement.
> I notice you don't run "make check". It is highly recommended (maybe in
a
> future revision of the spkg), especially since spkg-install uses
different
> values of CC/CFLAGS than the upstream package would choose.
>
In this case checks are run if SAGE_CHECK is set during building. There
are few spkg where the test suite is systematically run. I guess there
would be a call for it if the packge was troublesome on a regular basis.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14151#comment:36>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
