#5487: [with patch, needs review] Content function for tableaux
---------------------------+------------------------------------------------
Reporter: andrew.mathas | Owner: andrew.mathas
Type: enhancement | Status: new
Priority: trivial | Milestone: sage-combinat
Component: combinatorics | Keywords: tableaux content
---------------------------+------------------------------------------------
Comment(by hivert):
Dear Andrew,
Sorry for bothering you with this first simple patch but before giving a
positive review I'd rather see the following first problem fixed. I leave
these to you because I understand that you want test the patch workflow.
If you want me to fix these please ask.
1. I agree with Franco's first message: I'd rather raise an error than
return False silently. Those {{{False}}} or {{{None}}} tends to crawl into
the programs and to eventually trigger an error at the wrong place. You
can always catch the exception if you want. I think {{{ValueError}}} is
the correct exception (see the similar behavior for list below).
2. I case you don't know, in python, when you have a list {{{l}}} the call
{{{l.index(k)}}} either returns the first position of {{{k}}} if it is in
the list or raise a
{{{
ValueError: list.index(x): x not in list
}}}
maybe it's worth using it ?
cheers,
Florent
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5487#comment:7>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
