#12173: Update FLINT to 2.3
---------------------------------------------------------------------+------
Reporter: mhansen |
Owner: tbd
Type: enhancement |
Status: needs_info
Priority: major |
Milestone: sage-5.10
Component: packages: standard |
Resolution:
Keywords: flint spkg | Work
issues:
Report Upstream: N/A |
Reviewers: John Cremona, Jeroen Demeyer
Authors: Mike Hansen, Fredrik Johansson, Jean-Pierre Flori |
Merged in:
Dependencies: #12433, #14393 |
Stopgaps:
---------------------------------------------------------------------+------
Comment (by jpflori):
Indeed, some pieces went missing or were inadvertently added.
* sage/ext/gen_interpreters.py, spurious case change not fixed in the
"fixes" patch, so this hunk is needed;
* sage/groups/perm_gps/partn_ref/data_structures_pxd.pxi, I missed this
one, we should modify
"s|sage\.libs\.flint\.long_extras|sage.libs.flint.ulong_extras|g" in the
script by omitting the "sage.libs" part
* sage/libs/flint/fmpq_poly.pxd, ignore this hunk, it just adds a spurious
newline
* sage/libs/flint/fmpz_poly.pxi, the first hunk is needed, not sure where
it went; the second hunk is more or less moving lines, in fact we could
even order the lines better; the third hunk was plain wrong and now
defines twice "fmpz_poly_scalar_fdiv_ui", so the solution is to remove
that line completely.
* sage/libs/flint/ntl_interface.pxd, should be applied; ZZ_limbs does not
exists anymore, and in fact the previous declaration of fmpz_to_mpz here
was misplaced... even though fmpz_get_ZZ is unused, its place is here so
the all in one patch is right.
* sage/modular/modform/eis_series.py, discard this hunk, we forgot to
rename a zmod to nmod before (within a comment).
An additional change would make sense:
* sage/libs/flint/fmpz_poly.pxi: replace "fmpz_t fmpz_poly_get_coeff_ptr"
by "fmpz* fmpz_poly_get_coeff_ptr", and maybe remove the commented out
line (fmpz_poly_scalar_mul), cleanup spaces
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12173#comment:281>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
