#14496: unify the three implementations of gaussian q-binomial coefficients
-------------------------------------+--------------------------------------
Reporter: chapoton | Owner: tbd
Type: task | Status: needs_work
Priority: major | Milestone: sage-5.10
Component: combinatorics | Resolution:
Keywords: gaussian binomial | Work issues:
Report Upstream: N/A | Reviewers:
Authors: Frédéric Chapoton | Merged in:
Dependencies: | Stopgaps:
-------------------------------------+--------------------------------------
Changes (by fwclarke):
* status: needs_review => needs_work
Comment:
1. There's a doctest failure at line 341 of `sage/combinat/sf/kfpoly.py`.
I don't know what's being computed here, so I don't know what's going
wrong.
2. I thought the standard spacing was as
{{{
def gaussian_binomial(n, k, q=None):
}}}
3. I think `TypeError` is enough; I never saw anything else when I was
testing your code.
4. Is it intentional not to alter `sage/combinat/q_analogues.py` ?
So it's nearly ready for a positive review.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14496#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
