#14145: Problems with contains for Tableau, TableauTuples and PartitionTuples
---------------------------------------------------+------------------------
Reporter: andrew.mathas | Owner:
sage-combinat
Type: defect | Status:
needs_review
Priority: major | Milestone: sage-5.10
Component: combinatorics | Resolution:
Keywords: days45 | Work issues:
Report Upstream: N/A | Reviewers: Andrew
Mathas, Travis Scrimshaw
Authors: Travis Scrimshaw, Andrew Mathas | Merged in:
Dependencies: #13605 | Stopgaps:
---------------------------------------------------+------------------------
Changes (by {'newvalue': u'Travis Scrimshaw, Andrew Mathas', 'oldvalue':
u'Travis Scrimshaw'}):
* reviewer: Andrew Mathas => Andrew Mathas, Travis Scrimshaw
* author: Travis Scrimshaw => Travis Scrimshaw, Andrew Mathas
Comment:
Hi Travis,
I finally got back to this. I looked more closely at the changes in timing
before and after the patch and I think that they are not in fact due to
element creation but instead are caused by the lazy imports. For example,
the biggest slowdown (from 0s to 6.51s) occurs with the lines
{{{#!python
G = SymmetricGroup(8)
g = G([(1,2,3,4,5),(6,7,8)])
}}}
I have just pushed a slight modification to the patch to the combinat
queue which changes the sanity checking in Partition.__init__. I ran a few
tests and the new code is slightly faster than the old code.
Finally, as my first review patch was more 4 times bigger than your patch
I have made us both authors and reviewers.
If you are happy with it then let's make this a positive review.
Andrew
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14145#comment:8>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
