#14248: Add case sensitive to global options
------------------------------------+---------------------------------------
       Reporter:  tscrim            |         Owner:  sage-combinat  
           Type:  enhancement       |        Status:  positive_review
       Priority:  major             |     Milestone:  sage-5.10      
      Component:  misc              |    Resolution:                 
       Keywords:  global options    |   Work issues:                 
Report Upstream:  N/A               |     Reviewers:                 
        Authors:  Travis Scrimshaw  |     Merged in:                 
   Dependencies:  #13605            |      Stopgaps:                 
------------------------------------+---------------------------------------
Changes (by tscrim):

  * status:  needs_review => positive_review


Old description:

> Currently all string values are converted to lowercase in global options,
> so checks are case insensitive. This will add an option to allow case
> distinctions.

New description:

 Currently all string values are converted to lowercase in global options,
 so checks are case insensitive. This will add an option to allow case
 distinctions.

 Apply:

 * [attachment:trac_14249-global_options_case-ts.patch]

--

Comment:

 Hey Andrew,

 I've uploaded the patch which has your review patch folded in and makes
 the minor tweak above.  I'm setting this to positive review since we're in
 agreement about the patch (please correct me if I'm wrong).

 Thank you again for reviewing this,[[BR]]
 Travis


 For patchbot:

 Apply: trac_14249-global_options_case-ts.patch

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14248#comment:17>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to