#13525: PALP/Laurent Normal Form
----------------------------------+-----------------------------------------
       Reporter:  sjg10           |         Owner:  mhampton    
           Type:  enhancement     |        Status:  needs_review
       Priority:  major           |     Milestone:  sage-5.10   
      Component:  geometry        |    Resolution:              
       Keywords:                  |   Work issues:              
Report Upstream:  N/A             |     Reviewers:              
        Authors:  Samuel Gonshaw  |     Merged in:              
   Dependencies:  #14319          |      Stopgaps:              
----------------------------------+-----------------------------------------
Changes (by vbraun):

  * dependencies:  => #14319


Comment:

 #14319 improves the graph automorphisms so you don't have to track the
 relabeling any more. This would simplify the code here, too.

 As a minor nitpick, pep8 would be nice:
 {{{
 def palp_modified_normal_form(L,affine_transform=False,certify=False):
 # no
 def palp_modified_normal_form(L, affine_transform=False, certify=False):
 # yes
 }}}
 Also, docstring should be imperative: "Return foobar". Not: "Returns
 foobar" or "We return foobar".

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13525#comment:12>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to