#5789: [with patch; needs review] create sagelite
--------------------------+-------------------------------------------------
 Reporter:  was           |       Owner:  mabshoff  
     Type:  enhancement   |      Status:  new       
 Priority:  major         |   Milestone:  sage-3.4.1
Component:  distribution  |    Keywords:            
--------------------------+-------------------------------------------------

Comment(by certik):

 The bundle works fine for me and as far as I can tell, it's +1. However,
 I'd like if somebody with more familiarity with the code could also look
 at it, since the patch imho touches important things.

 Some comments that I noticed: the following functions have doctests, but
 don't have any docstring, e.g. I was expecting some line about what the
 function does -- sometimes it's easy to infer from the example, sometimes
 it took me a while (e.g. the running_total):
 {{{
 +def prod(x, z=None):
 +    """

 +def running_total(L, start=None):
 }}}

 Anyway, this is minor.

 I run the tests for a sever:

 $ ./sage -t devel/sage/sage/server/

 They all pass for me.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5789#comment:5>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of 
Reinventing the Wheel

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to 
[email protected]
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to