#14346: Document/report/fix PARI patches
--------------------------------------+-------------------------------------
Reporter: Snark | Owner: tbd
Type: enhancement | Status: new
Priority: major | Milestone: sage-wishlist
Component: packages: standard | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers:
Authors: | Merged in:
Dependencies: | Stopgaps:
--------------------------------------+-------------------------------------
Old description:
> This spkg has 15 patches, with the following:
>
> Good:
> * get_ld.patch: author known, pure packaging
> * get_tests.patch: author known, pure packaging
> * install_doc_no_make.patch: author known, pure packaging
> * perl_path.patch: author known, pure packaging
> * cygwin_dll_a.patch: author known, pure packaging
>
> Bad:
> * get_config_options.patch: author known, upstream-worthy, no comment
> says it was forwarded, which probably means it wasn't
> * get_fltk.patch: author known, upstream-worthy, no comment says it was
> forwarded, which probably means it wasn't
> * get_X11.patch: author known, upstream-worthy, no comment says it was
> forwarded, which probably means it wasn't
> * mp.c.patch: author unknown, should be replaced by a Sage library
> patch.
>
> Needs documentation:
> * galoisanalysis_p4.patch: author (jdemeyer) not mentioned, add link to
> upstream report: http://pari.math.u-bordeaux.fr/cgi-
> bin/bugreport.cgi?bug=1389
> * GCC_PR49330.patch: author (jdemeyer) not mentioned, discussed with
> upstream, upstream decided not to fix this. Should mention
> [http://pari.math.u-bordeaux.fr/archives/pari-dev-1203/msg00000.html] and
> [http://pari.math.u-bordeaux.fr/archives/pari-dev-1202/msg00006.html]
> * get_dlcflags.patch: author known, partially accepted by upstream.
> * KERNELCFLAGS.patch: author unknown, you have to look at a bug report
> to see who the author is and that it was forwarded upstream
> * trac_13902_determinant.patch: author (jdemeyer) not mentioned,
> upstream backport
> * polred.patch: author (jdemeyer) not mentioned, upstream backport
New description:
This spkg has many patches, with the following:
Good:
* get_ld.patch: author known, pure packaging
* get_tests.patch: author known, pure packaging
* install_doc_no_make.patch: author known, pure packaging
* perl_path.patch: author known, pure packaging
* cygwin_dll_a.patch: author known, pure packaging
Bad:
* get_config_options.patch: author known, upstream-worthy, no comment
says it was forwarded, which probably means it wasn't
* get_fltk.patch: author known, upstream-worthy, no comment says it was
forwarded, which probably means it wasn't
* get_X11.patch: author known, upstream-worthy, no comment says it was
forwarded, which probably means it wasn't
* mp.c.patch: author unknown, should be replaced by a Sage library patch.
Needs documentation:
* GCC_PR49330.patch: author (jdemeyer) not mentioned, discussed with
upstream, upstream decided not to fix this. Should mention
[http://pari.math.u-bordeaux.fr/archives/pari-dev-1203/msg00000.html] and
[http://pari.math.u-bordeaux.fr/archives/pari-dev-1202/msg00006.html]
* get_dlcflags.patch: author known, partially accepted by upstream.
* KERNELCFLAGS.patch: author unknown, you have to look at a bug report to
see who the author is and that it was forwarded upstream
* trac_13902_determinant.patch: author (jdemeyer) not mentioned, upstream
backport
* polred.patch: author (jdemeyer) not mentioned, upstream backport
--
Comment (by jdemeyer):
In #14539, I updated the patches README. Please verify that all needed
documentation has been added.
I remove the mention of `galoisanalysis_p4.patch` since that patch is
upstream in PARI-2.5.4 and therefore not needed anymore.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14346#comment:34>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
