#14562: Steiner Quadruple Systems
---------------------------------+------------------------------------------
Reporter: ncohen | Owner: sage-combinat
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.10
Component: combinatorics | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers:
Authors: Nathann Cohen | Merged in:
Dependencies: | Stopgaps:
---------------------------------+------------------------------------------
Comment (by vbraun):
If speed is really an issue then you should switch to Cython, which will
expand `for i in range()` directly into the corresponding C loop. So there
isn't that much need for `xrange()` in Sage.
Your blank lines are oppositie to PEP8:
http://www.python.org/dev/peps/pep-0008/#blank-lines... One could take out
most blank lines in functions without losing anything. Especially nested
loops are visually already well-separated without blank lines. But its not
a big deal.
Is anybody on this ticket running any further mathematical tests? if not
-> positive review.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14562#comment:14>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
