#12090: Arrangements of pseudolines
---------------------------------+------------------------------------------
Reporter: ncohen | Owner: mhampton
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.10
Component: geometry | Resolution:
Keywords: | Work issues: needs rebase
Report Upstream: N/A | Reviewers:
Authors: Nathann Cohen | Merged in:
Dependencies: #12159 #11634 | Stopgaps:
---------------------------------+------------------------------------------
Comment (by hthomas):
I (trivially) rebased the patch so it applies.
I also uploaded a review patch (separate for ease of review). I changed
!PseudolinesArrangement to !PseudolineArrangement. I think this is more
idiomatic. I made other minor changes to the English throughout.
I slightly moved the labels in the wiring diagram output, so they don't
overlap the diagram.
I made a small change which simplifies slightly the logic of the reading
of the Felsner encoding. Maybe there was a reason for the way it was, but
I couldn't see it. Please check me!
I'm not too happy about this:
{{{
sage: from sage.geometry.pseudolines import PseudolineArrangement
sage: t=PseudolineArrangement([(1,2),(0,2),(1,0)],encoding="permutations")
sage: s=PseudolineArrangement(([1,2],[0,2],[1,0]),encoding="permutations")
sage: r=PseudolineArrangement([[1,2],[0,2],[1,0]],encoding="permutations")
sage: s==r
False
sage: t==r
False
}}}
Do you think the fact that the documentation refers to lists is enough to
warn the user not to use tuples? It was a pleasure (and instructive!) to
read your very efficient code, so I didn't want to mess it up with a
clumsy attempt to handle this myself.
apply trac_12090-rebase.patch, trac_12090-review.patch
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12090#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
