#12728: sage's spkg sources should use correct include paths instead of having
../../../../whatever everywhere
--------------------------------+-------------------------------------------
Reporter: Snark | Owner: Snark
Type: enhancement | Status: needs_work
Priority: minor | Milestone: sage-5.10
Component: build | Resolution:
Keywords: | Work issues: rebase
Report Upstream: N/A | Reviewers: Volker Braun, Jeroen Demeyer
Authors: Julien Puydt | Merged in:
Dependencies: | Stopgaps:
--------------------------------+-------------------------------------------
Changes (by jdemeyer):
* status: needs_review => needs_work
* reviewer: Volker Braun => Volker Braun, Jeroen Demeyer
* work_issues: => rebase
Old description:
> There are many places in sage's spkg sources where inclusions are made
> with a filename which looks like ../../../../../whatever (no exageration:
> up to *five* levels!).
>
> Those should be removed, and the right path added to the include line.
>
> Apply trac_12728_5.10.beta3.patch and trac_12728_5.10.beta3-hand.patch.
>
> (The first patch was obtained by running the attached script and the
> second one by hand-editing the remaining occurrences.)
>
> (The first patch was already reviewed by Volker, but not the second)
New description:
There are many places in sage's spkg sources where inclusions are made
with a filename which looks like ../../../../../whatever (no exageration:
up to *five* levels!).
Those should be removed, and the right path added to the include line.
Apply [attachment:trac_12728_5.10.beta3.patch] and
[attachment:trac_12728_5.10.beta3-hand.patch]
(The first patch was obtained by running the attached script and the
second one by hand-editing the remaining occurrences.)
(The first patch was reviewed by Volker, the second by Jeroen)
--
Comment:
Positive review to [attachment:trac_12728_5.10.beta3_hand.patch]
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12728#comment:34>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
