#12728: sage's spkg sources should use correct include paths instead of having
../../../../whatever everywhere
--------------------------------+-------------------------------------------
       Reporter:  Snark         |         Owner:  Snark                       
           Type:  enhancement   |        Status:  positive_review             
       Priority:  minor         |     Milestone:  sage-5.10                   
      Component:  build         |    Resolution:                              
       Keywords:                |   Work issues:                              
Report Upstream:  N/A           |     Reviewers:  Volker Braun, Jeroen Demeyer
        Authors:  Julien Puydt  |     Merged in:                              
   Dependencies:                |      Stopgaps:                              
--------------------------------+-------------------------------------------
Changes (by vbraun):

  * dependencies:  #14634 =>
  * milestone:  sage-pending => sage-5.10


Old description:

> '''Problem'''
>
> There are many places in sage's spkg sources where inclusions are made
> with a filename which looks like ../../../../../whatever (no exageration:
> up to *five* levels!).
>
> '''Solution'''
> Those should be removed, and the right path added to the include line.
>
> Apply [attachment:trac_12728_5.10.beta4_auto.patch] and
> [attachment:trac_12728_5.10.beta4_hand.patch]
>
> (The first patch was obtained by running the attached script and the
> second one by hand-editing the remaining occurrences.)

New description:

 '''Problem'''

 There are many places in sage's spkg sources where inclusions are made
 with a filename which looks like ../../../../../whatever (no exageration:
 up to *five* levels!).

 '''Solution'''
 Those should be removed, and the right path added to the include line.


 The first patch was obtained by running the attached script and the second
 one by hand-editing the remaining occurrences.

 Apply
   * [attachment:trac_12728_5.10.beta4_auto.patch]
   * [attachment:trac_12728_5.10.beta4_hand.patch]
   * [attachment:trac_12728_docbuild_workaround.patch]

--

Comment:

 I suggest we just revert the two includes that trigger the Cython bug.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12728#comment:52>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to