#14123: Adding new combinatorial maps to binary trees
---------------------------------+------------------------------------------
       Reporter:  VivianePons    |         Owner:  sage-combinat  
           Type:  enhancement    |        Status:  needs_review   
       Priority:  major          |     Milestone:  sage-5.10      
      Component:  combinatorics  |    Resolution:                 
       Keywords:  days45         |   Work issues:                 
Report Upstream:  N/A            |     Reviewers:  Christian Stump
        Authors:  Viviane Pons   |     Merged in:                 
   Dependencies:  #8703          |      Stopgaps:                 
---------------------------------+------------------------------------------

Comment (by stumpc5):

 Hi Viviane --

 I updated the patch with tons of minor changes (unfortunately, I didn't do
 it in a separate file to actually show the diff, sorry):

 - I removed tons of trailing white spaces, and empty lines
 - it's worth looking at the docbuild outcome to see what code is not yet
 rendering as desired.
   - you often tried to use math code, but sphinx wasn't able to figure it
 out (like in {{{a string, either `1L0R`,`1R0L`,`L1R0`,`R1L0`}}}). I
 replaced these.
   - when writing rst over multiple lines, please see that the indention is
 right, I also fixed several itemize going over several lines.

 I hope I fixed everything, but feel free to look over it, and possibly do
 further changes. Otherwise, I'll give it a positive review as soon as the
 patchbot is happy.

 Cheers, Christian

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14123#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to