#14615: cythonize lazy_atrtibute
-------------------------------+--------------------------------------------
Reporter: nbruin | Owner: tbd
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.10
Component: performance | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers: Travis Scrimshaw
Authors: Nils Bruin | Merged in:
Dependencies: | Stopgaps:
-------------------------------+--------------------------------------------
Changes (by {'newvalue': u'Nils Bruin', 'oldvalue': ''}):
* reviewer: => Travis Scrimshaw
* author: => Nils Bruin
Old description:
> cythonize `lazy_attribute` so that it provides acceptable performance on
> cython classes that don't have a `__dict__` but do have a
> `__cached_methods` dictionary.
>
> In the current design, we let `lazy_attribute` inherit from a `cdef
> class` `_lazy_attribute` that implements all the time-critical stuff
> (including a `cdef` slot for `__name__`). `lazy_attribute is a
> conventional class so that we can override documentation and module on
> it, which was previously done for introspection reasons. This inheritance
> construction seems to have minimal runtime consequences.
New description:
cythonize `lazy_attribute` so that it provides acceptable performance on
cython classes that don't have a `__dict__` but do have a
`__cached_methods` dictionary.
In the current design, we let `lazy_attribute` inherit from a `cdef class`
`_lazy_attribute` that implements all the time-critical stuff (including a
`cdef` slot for `__name__`). `lazy_attribute` is a conventional class so
that we can override documentation and module on it, which was previously
done for introspection reasons. This inheritance construction seems to
have minimal runtime consequences.
----
Apply: [attachment:trac_14615-cythonize_lazy_attribute-v2.patch]
--
Comment:
Hey Nils,
I've uploaded a new version of the patch which renames the file instead of
an add/delete. I've also moved the doc from `_lazy_attribute` to
`lazy_attribute` and brought the doc up to our current standard.
If you're happy with my changes, you can set this to positive review.
Best,[[BR]]
Travis
Here are my timings:
{{{
sage: %timeit t.t
1000000 loops, best of 3: 365 ns per loop
}}}
Without the patch:
{{{
sage: %timeit t.t
1000000 loops, best of 3: 1.59 us per loop
}}}
PS - As a word of warning to anyone who wants to test this, this basically
caused sage to recompile for me.
For patchbot:
Apply: trac_14615-cythonize_lazy_attribute-v2.patch
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14615#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
